Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] fix error in argmin UT when dtype=int16 #431

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

awayzjj
Copy link
Collaborator

@awayzjj awayzjj commented Jan 21, 2025

PR Category

Type of Change

Description

Issue

  1. The tl.min function will upcast an int16 input tensor to int32 on iluvatar. Therefore, the min_values should be initialized with dtype=int32; otherwise, the Triton IR cannot be generated.
  2. add tune config of batchnorm

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@awayzjj awayzjj marked this pull request as ready for review January 21, 2025 08:55
Copy link
Collaborator

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It is a temporary workaround to avoid promoting min_values to float32 when value is of type tl.int16.

@iclementine iclementine merged commit a381132 into FlagOpen:master Jan 24, 2025
8 of 9 checks passed
@iclementine iclementine self-assigned this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants