Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROPE supports auto deducing position_ids #74

Merged
merged 4 commits into from
Jun 21, 2024
Merged

ROPE supports auto deducing position_ids #74

merged 4 commits into from
Jun 21, 2024

Conversation

pingzhuu
Copy link
Collaborator

Rope supports automatically inferring position ids if this parameter is not provided.

@pingzhuu pingzhuu added the enhancement New feature or request label Jun 18, 2024
@StrongSpoon
Copy link
Collaborator

please format your code using pre-commit

tongxin
tongxin approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tongxin tongxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@tongxin tongxin merged commit 25a2125 into master Jun 21, 2024
3 checks passed
@StrongSpoon StrongSpoon deleted the refine_rope_posision_ids branch July 15, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iclementine iclementine iclementine approved these changes

@tongxin tongxin tongxin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pingzhuu @StrongSpoon @tongxin @iclementine