[Operator] Type promotion for pointwise Ops #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Bowen12992
commented
Jun 21, 2024
•
Bowen12992
commented
- Add Type promotion for pointwise Ops
- Add trunc & floor mode for divOp
- Move Type promotion into pointwise JIT
- Support different condition of whereOp
- Add UTs of type promotion for pointwise Ops
- Fix related docs
iclementine
reviewed
Jun 25, 2024
| import torch._prims_common as utils | ||
|
|
||
|
|
||
| def type_promotion(*args, type_promotion: utils.ELEMENTWISE_TYPE_PROMOTION_KIND): |
There was a problem hiding this comment.
Maybe we can use a simpler implementation for type promotion rules.(e.g. use torch.promote_types or torch.result_type for ELEMENTWISE_TYPE_PROMOTION_KIND.DEFAULT, and write our own implementation for other cases).
There was a problem hiding this comment.
Yeah, we can simplify the logic! but I have two concerns. 1. Will Gems support dynamic-shape with maybe sympy in the feature？2. I‘m going to figure out if there are differences among torch.promote_types torch.result_type and ELEMENTWISE_TYPE_PROMOTION_KIND.DEFAULT
There was a problem hiding this comment.
We may not support symbolic shape since flaggems is basically designed for processing real tensors, with concrete shapes.
iclementine
reviewed
Jun 25, 2024
StrongSpoon
reviewed
Jun 26, 2024
Bowen12992
changed the title
Bowen12992
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.