[operator] fix libentry to support triton 2.3 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
StrongSpoon
commented
Jun 28, 2024
StrongSpoon
commented
- modified libentry arguments collection, cache key generation and constexpr collection
- specify dns arguments for operators
- works for triton 2.2 and 2.3
tongxin
reviewed
Jul 2, 2024
| @@ -82,7 +82,7 @@ def dropout_forward_kernel( | |||
| "N", | |||
| ], | |||
| ) | |||
| @triton.jit | |||
| @triton.jit(do_not_specialize=["p", "philox_seed", "philox_offset"]) | |||
There was a problem hiding this comment.
Does Triton specialize on floats?
There was a problem hiding this comment.
floats not marked as dns are specialized as False
src/flag_gems/utils/libentry.py
Outdated
| @@ -14,47 +16,110 @@ def __init__( | |||
| while not isinstance(fn, triton.runtime.JITFunction): | |||
| fn = fn.fn | |||
| self.jit_function: triton.runtime.JITFunction = fn | |||
| self.kernel_arg_indices = [] | |||
| self.spec_indices = [] | |||
| self.dns_indices = [] | |||
There was a problem hiding this comment.
let's be more precise? do_not_specialize_indices
src/flag_gems/utils/libentry.py
Outdated
Comment on lines
21
to
26
| for p in self.jit_function.params: | ||
| if not p.is_constexpr: | ||
| self.kernel_arg_indices.append(p.num) | ||
| if p.do_not_specialize: | ||
| self.dns_indices.append(p.num) | ||
| else: | ||
| self.spec_indices.append(p.num) |
There was a problem hiding this comment.
Isn't a bit of list comprehension is more favorable than loops?
src/flag_gems/utils/libentry.py
Outdated
Comment on lines
30
to
36
| for arg in spec_args: | ||
| if hasattr(arg, "data_ptr"): | ||
| entry_key.append(str(arg.dtype)) | ||
| entry_key.append(arg.data_ptr() % self.divisibility == 0) | ||
| else: | ||
| entry_key.append(type(arg)) | ||
| entry_key.append(arg) |
There was a problem hiding this comment.
List comprehension is an immutable fashion for coding loops. It's normally more efficient than the mutable counterpart.
|
LGTM The triton jit runtime is too complicated.
After all, for quick understanding of the rationale, a cheatsheet is needed. |
iclementine
approved these changes
Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.