-
Notifications
You must be signed in to change notification settings - Fork 15
feat: cache priority and tests #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: cache priority and tests #96
Conversation
In order to unblock tests here, I've opened a mirror pull request in our repository so CI can pick up on secrets stored on our end, and run tests against the same ref as this patch. @polatolu There are some linting issues. Can you please check if they fall into the scope of your patch? We'll need to manually pull changes onto the above mirror for the time being — sorry this is a manual process on our end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good, thanks! We'll need to sort out some linting errors though.
@polatolu Do you have any updates on this? Let us know if you need any assistance! |
Hey @emyller we're trying to work out why the same lint rules have different behaviour on local and GitHub actions and will keep you posted, cheers |
Hi @emyller we've made quite a lot of changes based our internal PR foresightmobile#5 and we're confident that this should be ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Impressive job guys! I am astonished at the amount of changes needed to fix linting issues. Thank you for taking good care of it. We'll merge and release this soon (Monday probably) unless there's any other step to take? cc @matthewelwell |
Description
Fixed the caching mechanism priorities to use cached flags when API calls fails.
Regression Test Recommendations
Type of Change
✨ New feature (non-breaking change which adds functionality)