Skip to content

Conversation

polatolu
Copy link

@polatolu polatolu commented Oct 9, 2025

Description

Fixed the caching mechanism priorities to use cached flags when API calls fails.

Regression Test Recommendations

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ~ ❌ Breaking change (fix or feature that would cause existing functionality to change) ~
  • ~ 🧹 Code refactor ~
  • ~ ✅ Build configuration change ~
  • ~ 📝 Documentation ~
  • ~🗑️ Chore ~

@polatolu polatolu requested a review from a team as a code owner October 9, 2025 08:43
@polatolu polatolu requested review from Zaimwa9 and removed request for a team October 9, 2025 08:43
@matthewelwell matthewelwell changed the title Cache priority and tests feat: cache priority and tests Oct 9, 2025
@emyller
Copy link

emyller commented Oct 9, 2025

In order to unblock tests here, I've opened a mirror pull request in our repository so CI can pick up on secrets stored on our end, and run tests against the same ref as this patch.

@polatolu There are some linting issues. Can you please check if they fall into the scope of your patch?

We'll need to manually pull changes onto the above mirror for the time being — sorry this is a manual process on our end.

emyller
emyller previously approved these changes Oct 9, 2025
Copy link

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good, thanks! We'll need to sort out some linting errors though.

@emyller
Copy link

emyller commented Oct 15, 2025

@polatolu Do you have any updates on this? Let us know if you need any assistance!

@gazreese
Copy link
Contributor

Hey @emyller we're trying to work out why the same lint rules have different behaviour on local and GitHub actions and will keep you posted, cheers

@gazreese
Copy link
Contributor

Hi @emyller we've made quite a lot of changes based our internal PR foresightmobile#5 and we're confident that this should be ready to go now.

Copy link

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@emyller
Copy link

emyller commented Oct 17, 2025

Impressive job guys! I am astonished at the amount of changes needed to fix linting issues. Thank you for taking good care of it. We'll merge and release this soon (Monday probably) unless there's any other step to take? cc @matthewelwell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants