Skip to content

[fix] allow analytics to use the default api url if one isn't set #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[fix] allow analytics to use the default api url if one isn't set #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
855fdd4
fix: allow analytics to use the default api url if one isn't set
Aug 5, 2025
a91abab
docs: correct parameters name in phpdoc
Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Flagsmith.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function __construct(
$this->environmentTtl = $environmentTtl ?? $this->environmentTtl;
$this->enableLocalEvaluation = !is_null($environmentTtl);
$this->retries = $retries ?? new Retry(3);
$this->analyticsProcessor = $enableAnalytics ? new AnalyticsProcessor($apiKey, $host) : null;
$this->analyticsProcessor = $enableAnalytics ? new AnalyticsProcessor($apiKey, $this->host) : null;
$this->defaultFlagHandler = $defaultFlagHandler ?? $this->defaultFlagHandler;

//We default to using Guzzle for the HTTP client (as this is how it worked in 1.0)
Expand Down Expand Up @@ -146,7 +146,7 @@ public function withEnvironmentTtl(int $environmentTtl): self

/**
* Build with enable Analytics.
* @param bool $enableAnalytics
* @param AnalyticsProcessor $analytics
* @return Flagsmith
*/
public function withAnalytics(AnalyticsProcessor $analytics): self
Expand Down