Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingTODO
This is obviously a work-in-progress, but I wanted to put this up early to signal that I was working on it. The plan is to complete this before June 20 when I have to go back to work.
Changes
As per #72 , I've added new webhook events as follows:
FLAG_FEATURE_CREATED
=> newFLAG_FEATURE_DELETED
=> renamed fromFLAG_DELETED
FLAG_FEATURE_UPDATED
=> renamed fromFLAG_UPDATED
FLAG_IDENTITY_UPDATED
=> newFLAG_SEGMENT_CREATED
=> newFLAG_SEGMENT_DELETED
=> newFLAG_SEGMENT_UPDATED
=> newAUDIT_LOG_CREATED
=> unchangedI intentionally left out events for identities being created or deleted as I wasn't sure if those would be useful and they weren't called out in the original issue.
How did you test this code?
Please describe.