Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more webhook event types #2310

Conversation

AphonicChaos
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

TODO

This is obviously a work-in-progress, but I wanted to put this up early to signal that I was working on it. The plan is to complete this before June 20 when I have to go back to work.

  • walk through where events are emitted and update to the correct type
  • find code paths for untracked events and start emitting them
  • write unit tests and fill out section below

Changes

As per #72 , I've added new webhook events as follows:

  • FLAG_FEATURE_CREATED => new
  • FLAG_FEATURE_DELETED => renamed from FLAG_DELETED
  • FLAG_FEATURE_UPDATED => renamed from FLAG_UPDATED
  • FLAG_IDENTITY_UPDATED => new
  • FLAG_SEGMENT_CREATED => new
  • FLAG_SEGMENT_DELETED => new
  • FLAG_SEGMENT_UPDATED => new
  • AUDIT_LOG_CREATED => unchanged

I intentionally left out events for identities being created or deleted as I wasn't sure if those would be useful and they weren't called out in the original issue.

How did you test this code?

Please describe.

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 11:14am

@vercel
Copy link

vercel bot commented Jun 17, 2023

@Aspidites is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@AphonicChaos
Copy link
Contributor Author

Didn't realize this was being worked on, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Hook sends only one type of event (FLAG_UPDATED)
1 participant