-
Notifications
You must be signed in to change notification settings - Fork 440
feat: backend-clone-segments #5393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
for more information, see https://pre-commit.ci
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/5393 ⚙️ Updating now by workflow run 15249039850. What is Uffizzi? Learn more! |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5393 +/- ##
========================================
Coverage 97.65% 97.66%
========================================
Files 1235 1237 +2
Lines 43334 43473 +139
========================================
+ Hits 42317 42456 +139
Misses 1017 1017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…agsmith into feat/backend-clone-segments
Co-authored-by: Evandro Myller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great. A few minor adjustments needed — sorry we didn't have time while pairing today, but we're close!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
This PR implements the backend cloning/duplication of segments
CloneSegmentSerializer
, requiring a name and performing the duplication/api/v1/projects/{projectId}/segments/{segmentId}/clone/
accepting a (required) name as body payloaddeep_clone_for_new_entity
, taking an entity (segment/env/feature) to deep clone and create the related new metadataHow did you test this code?
feat/clone-segments-and-feature-segments
Project Segment creation
https://www.loom.com/share/27ec8d4a2d8d4c24b443ac5d2b12231e?focus_title=1&muted=1&from_recorder=1
Feature specific segment creation
https://www.loom.com/share/8cc4d8e92ce84c459dfb6598ebb42acb