-
Notifications
You must be signed in to change notification settings - Fork 448
feat: use-project-id-from-context #5547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Docker builds report
|
I tested and it works without any issues. Is the idea using useRouteContext instead of useParams and useRouteMatch ? |
Yes that would be the idea. Especially for projectId (less important for environmentID being a string). So it's accessible from only one place instead of having an util or dealing with the type every time |
Ok, can you create a ticket for replacing every place that's using |
Did it directly in this PR but I'll create a ticket to re-type the component using it as a string |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
The objective of this PR is to provide a single source for current projectId/environmentId/organisationId (based on url)
How did you test this code?
Please describe.