api_client: accept session #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviau
force-pushed
the
aviau/session
branch
3 times, most recently
from
4769ebe to
0b8c6cc
Compare
isra17
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to pass a requests.session that might have adapters for retrying, backoff, etc.
As a user of the lib, I found myself wanting to enable requests retries and it would have been simple if I coul control the session.
What do we think? The downside is that it might interfere with retry features that we might want to bake in the lib ourselves. But I think the approach right now is to keep this lib very light and keep things simple.
in a follow-up PR I'll make it so that the Session that we create has an adapter with good defaults for retries