implement retries #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviau
force-pushed
the
aviau/retry
branch
4 times, most recently
from
f2abbb2 to
2d375c3
Compare
isra17
reviewed
Aug 19, 2024
|
WDYT @isra17 ? I tested and it works. I wish I could have a unit test but not really possible with requests-mock. The leaksdb/sources endpoint fails a lot (separate bug), and it made my script stable! |
|
I don't think I would enable retry by default. Actually, the more I think about it, the more I would rather just document how to do it through custom session and not build this in the client sdk. |
|
Hmm, I don't mind documenting custom sessions, but I think this might fix problems for most users at little cost. |
isra17
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for now.
I think this does not play well with requests-mock, so we can't test it really.