Moved the business logic of the configuration steps in the specific steps #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyMarc
force-pushed
the
mahinse/move_business_logic_to_steps
branch
3 times, most recently
from
9b9402b to
13f71a7
Compare
TyMarc
force-pushed
the
mahinse/move_business_logic_to_steps
branch
2 times, most recently
from
f23cadd to
76fdc3b
Compare
markkasaboski
approved these changes
Nov 27, 2024
…teps - Added an API key validation to determine if the key is valid instead of fetching the user tenants - Makefile: No need to check if we have python tests anymore, we do have them - Removed the splunk.min.js file since it's injected by splunk, removed the compilation of javascript files - Created constants file for typescript since it was getting all over the place - Added disabled step for buttons to block the user from submitting before the step is loaded
TyMarc
force-pushed
the
mahinse/move_business_logic_to_steps
branch
from
76fdc3b to
334a038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-27.at.2.15.13.PM.mov