Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the option from 'Ingest metadata only' to 'Ingest full event data' and make it off by default #73

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

TyMarc
Copy link
Contributor

@TyMarc TyMarc commented Dec 6, 2024

Screen.Recording.2024-12-06.at.3.45.17.PM.mov

@TyMarc TyMarc requested a review from sebd11 December 6, 2024 20:22
@TyMarc TyMarc self-assigned this Dec 6, 2024
@aviau
Copy link
Member

aviau commented Dec 6, 2024

so fastttt

@aviau
Copy link
Member

aviau commented Dec 6, 2024

I imagine we need a frontend change too? Can you post a screenshot?

@TyMarc
Copy link
Contributor Author

TyMarc commented Dec 6, 2024

Added video in description @aviau

@aviau
Copy link
Member

aviau commented Dec 6, 2024

Can we reverse the checkbox?

Name it "Full Event Ingestion", and turn it off by default.

@TyMarc TyMarc force-pushed the mahinse/change_ingest_metadata_default branch from a43184c to 40cf7d3 Compare December 6, 2024 20:46
@TyMarc TyMarc changed the title Ingest metadata only should be true by default Change the option from 'Ingest metadata only' to 'Ingest full event data' and make it off by default Dec 6, 2024
@TyMarc
Copy link
Contributor Author

TyMarc commented Dec 6, 2024

@aviau I updated the video

@TyMarc TyMarc force-pushed the mahinse/change_ingest_metadata_default branch from 40cf7d3 to 4a5548a Compare December 6, 2024 20:48
@TyMarc TyMarc requested review from markkasaboski and aviau December 6, 2024 21:08
@TyMarc TyMarc merged commit f5d7375 into main Dec 6, 2024
2 checks passed
@TyMarc TyMarc deleted the mahinse/change_ingest_metadata_default branch December 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants