Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coral arm #34

Merged
merged 11 commits into from
Jan 29, 2025
Merged

Coral arm #34

merged 11 commits into from
Jan 29, 2025

Conversation

ShalevAtA
Copy link
Contributor

No description provided.

tomtzook
tomtzook requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't finished all the things requested in the issue

src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/CoralArm.java Show resolved Hide resolved
tomtzook
tomtzook requested changes Jan 26, 2025
View reviewed changes
Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why buy you deleted good code from the command and did weird things instead. Please revert the command to its good state and change exactly as I've requested.

src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
tomtzook
tomtzook requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some progress

src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CoralArmCommand.java Outdated Show resolved Hide resolved
@tomtzook tomtzook merged commit 89bb139 into master Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtzook tomtzook tomtzook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShalevAtA @tomtzook @Tartar371