Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ktor-server-kafka README #35

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix ktor-server-kafka README #35

merged 1 commit into from
Jun 18, 2024

Conversation

yonatankarp
Copy link
Collaborator

This commit fixes a small mistake in the ktor-server-kafka plugin where the schema registry URL was expecting a list of strings, while the actual implementation accepts only a single string.

This commit fixes a small mistake in the ktor-server-kafka plugin where the schema registry URL was expecting a list of strings, while the actual implementation accepts only a single string.
Copy link
Owner

@Flaxoos Flaxoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@yonatankarp
Copy link
Collaborator Author

@Flaxoos you need to update your repo settings, it seems to not allow external contributions at this point:

image

@Flaxoos Flaxoos merged commit 48bab3e into Flaxoos:main Jun 18, 2024
1 check passed
@Flaxoos
Copy link
Owner

Flaxoos commented Jun 18, 2024

@yonatankarp Done, squashed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants