Implement transformation of header #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement transformation of header
|
@Dschee i merged in your changes since github just gave me a button to do that. the CI fails because it's not configured correctly i think?
|
Jeehut
changed the title
Jeehut
requested changes
May 8, 2019
There was a problem hiding this comment.
Please see my comments. Also there are a few other things:
- Please don't use the merge button on GitHub (it breaks history), instead, rebase properly on your machine.
- Please update the documentation with your changes.
- Please add an entry to the
Changedsection in the CHANGELOG.md. - I updated the CI configuration and it's building fine now on the stable. Yours should pass, too now.
| @@ -176,7 +176,7 @@ public class CSVImporter<T> { | |||
| /// - recordMapper: A closure to map the dictionary data interpreted from a line to your data structure. | |||
| /// - Returns: `self` to enable consecutive method calls (e.g. `importer.startImportingRecords {...}.onProgress {...}`). | |||
| public func startImportingRecords( | |||
| structure structureClosure: @escaping (_ headerValues: [String]) -> Void, | |||
| structure structureClosure: @escaping (_ headerValues: [String]) -> [String], | |||
There was a problem hiding this comment.
I think this should be marked as @discardableResult so code with current behavior doesn't break.
| @@ -235,16 +234,15 @@ public class CSVImporter<T> { | |||
| /// - recordMapper: A closure to map the dictionary data interpreted from a line to your data structure. | |||
| /// - Returns: The imported records array. | |||
| public func importRecords( | |||
| structure structureClosure: @escaping (_ headerValues: [String]) -> Void, | |||
| structure structureClosure: @escaping (_ headerValues: [String]) -> [String], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes. #44.