Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Agent FormatException: Invalid HTTP header field value #135

Closed
wants to merge 4 commits into from
Closed

User-Agent FormatException: Invalid HTTP header field value #135

wants to merge 4 commits into from

Conversation

litang0908
Copy link

API request failed if there are Chinese characters in User Agent. so encode ua by Uri.encodeComponent.

Here is the error message:

FormatException: Invalid HTTP header field value: "MacBookPro18,3, Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000, 版本13.5.1（版号22G90）" (at character 120)
...2:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000, 版本13.5.1（版号22G90）

@litang0908
FIX：User-Agent FormatException: Invalid HTTP header field value(Aser-…
7e08741 
…Agent will causes an error when there are Chinese characters).
@TesteurManiak TesteurManiak added bug Something isn't working priority-high High priority issues or PR labels Jan 25, 2024
TesteurManiak
TesteurManiak requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, those feedbacks are mostly related to the coding style to keep a consistent codebase.

lib/src/matomo.dart Outdated Show resolved Hide resolved
lib/src/matomo.dart Outdated Show resolved Hide resolved
lib/src/matomo.dart Outdated Show resolved Hide resolved
Pierre-Monier
Pierre-Monier reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@Pierre-Monier Pierre-Monier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @TesteurManiak, those changes will also make the CI happy

@TesteurManiak
Copy link
Member

@litang0908 Some tests are failing and should be fixed before merging.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@TesteurManiak TesteurManiak mentioned this pull request Feb 20, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Monier Pierre-Monier Pierre-Monier left review comments

@TesteurManiak TesteurManiak TesteurManiak requested changes

Assignees

@litang0908 litang0908

Labels
bug Something isn't working no-pr-activity priority-high High priority issues or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litang0908 @TesteurManiak @Pierre-Monier