Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows search empty paths #2271

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Fix windows search empty paths #2271

merged 2 commits into from
Aug 8, 2023

Conversation

Phoenix-
Copy link
Contributor

@Phoenix- Phoenix- commented Aug 7, 2023

Fix for #2270

Ignore 'file:' windows search results as they produce URI constructor exception.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jjw24
Copy link
Member

jjw24 commented Aug 7, 2023

Is it possible to compare dataReader.GetValue(1) so we can keep this check together with the db null checks?

@Phoenix-
Copy link
Contributor Author

Phoenix- commented Aug 7, 2023

Not sure if I should use {} around single-line blocks according to repo code style.

@Phoenix-
Copy link
Contributor Author

Phoenix- commented Aug 7, 2023

Is it possible to compare dataReader.GetValue(1) so we can keep this check together with the db null checks?

Sure. One moment

@jjw24
Copy link
Member

jjw24 commented Aug 7, 2023

Not sure if I should use {} around single-line blocks according to repo code style.

The style you got is correct, no need {}

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Phoenix-
Copy link
Contributor Author

Phoenix- commented Aug 7, 2023

Changed both columns checks to type checks instead of value, combined path column checks.

@Phoenix-
Copy link
Contributor Author

Phoenix- commented Aug 7, 2023

Added one more check to file extension(or directory flag), just in case.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (3)

CSearch
csm
WSearch

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Phoenix-/Flow.Launcher.git repository
on the dev branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5785371771/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 added bug Something isn't working Explorer Plugin Issue or Enhancement Link to Explorer Plugin labels Aug 8, 2023
@jjw24 jjw24 added this to the 1.16.1 milestone Aug 8, 2023
@jjw24 jjw24 enabled auto-merge August 8, 2023 02:19
@jjw24 jjw24 merged commit 7819171 into Flow-Launcher:dev Aug 8, 2023
@Phoenix-
Copy link
Contributor Author

Phoenix- commented Aug 8, 2023

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Explorer Plugin Issue or Enhancement Link to Explorer Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants