Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish installable default plugins to Store #2295

Merged
merged 17 commits into from
Aug 27, 2023
Merged

Publish installable default plugins to Store #2295

merged 17 commits into from
Aug 27, 2023

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Aug 16, 2023

Context:
Allows the user to reinstall a default plugin from the Store instead of having to reinstall flow entirely.

Changes:

  • All default plugins have their own repo for holding their releases
  • Use workflow to publish plugins to their repo if their plugin.json is modified
  • The actual installation code checks a plugin's ID against a list of default plugin IDs, if matches a default plugin's ID the install directory is changed to the program directory's plugin folder instead of the usual UserData location. This ensures that when flow is updated the default plugins are also reinstalled, otherwise if placed in UserData directory then will end up with duplicate default plugins.

Tests:

  • Workflow only runs when changes are detected in Plugins folder
  • Default plugins are published to their respective repositories when their plugin.json has been modified
  • Default plugins are not published if their plugin.json has not been modified
  • All installed default plugins work as expected
  • A default plugin is installed in the program's directory instead of userdata's plugin directory

Close #1984

@jjw24 jjw24 added the bug Something isn't working label Aug 16, 2023
@jjw24 jjw24 self-assigned this Aug 16, 2023
@jjw24 jjw24 added this to the 1.16.2 milestone Aug 16, 2023
@jjw24 jjw24 marked this pull request as draft August 16, 2023 12:18
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Aug 21, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (3)

alreadyexists
CETYU
noresult

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the deploy_plugins branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5931862752/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 marked this pull request as ready for review August 21, 2023 22:03
@jjw24 jjw24 enabled auto-merge August 21, 2023 22:04
@jjw24 jjw24 requested a review from Garulf August 21, 2023 22:08
@jjw24 jjw24 changed the title Publish default plugins Publish installable default plugins to Store Aug 21, 2023
@jjw24 jjw24 merged commit 0ab7490 into dev Aug 27, 2023
@jjw24 jjw24 deleted the deploy_plugins branch August 27, 2023 11:11
@jjw24 jjw24 mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default plugins installable from Plugin Store
2 participants