Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open target for program shortcuts #2508

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Conversation

flooxo
Copy link
Contributor

@flooxo flooxo commented Jan 25, 2024

This PR closes #2390.

Description

I added a new result in the context menu for programs to open the destination folder.
Only in win32 this new result is added, because UWP work differently and have no links, so "open containing folder" already opens the correct location automatically

Changes

Add open target folder option for programs

Signed-off-by: Florian Grabmeier <[email protected]>

This comment has been minimized.

@taooceros
Copy link
Member

mind putting up a screenshot for the result?

@VictoriousRaptor
Copy link
Contributor

I wonder how many options are in context menu.

@flooxo
Copy link
Contributor Author

flooxo commented Feb 20, 2024

mind putting up a screenshot for the result?

image
Sure! Thanks for the hint, I totally forgot

@flooxo
Copy link
Contributor Author

flooxo commented Feb 20, 2024

There are the following options:

  • Run As Different User
  • Run As Administrator
  • Open Containing Folder
  • Open Target Folder
  • Disable this program from displaying
  • Set as topmost in this query
  • Plugin: Program

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (7)

flowlauncher
inputing
IPublic
lnk
mscorlib
runas
Segoe

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:flooxo/Flow.Launcher.git repository
on the open_target branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8495324059/attempts/1'
Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@VictoriousRaptor
Copy link
Contributor

I've made some changes:

  • Add Args property so ExecutablePath and LnkResolvedPath no longer contains args.
  • Only show target folder context menu for .lnk files

@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Mar 31, 2024
@VictoriousRaptor VictoriousRaptor added this to the 1.18.0 milestone Mar 31, 2024
@jjw24 jjw24 merged commit 2796215 into Flow-Launcher:dev Mar 31, 2024
3 checks passed
@VictoriousRaptor
Copy link
Contributor

Looks like Win32.cache can't be loaded after updating and users need to manually reindex the programs.

@taooceros
Copy link
Member

Looks like Win32.cache can't be loaded after updating and users need to manually reindex the programs.

Will it throw the error? If so I guess the reindex will happen automatically. You might try the release build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program Plugin - Add an "Open shortcut's Target".
4 participants