Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.PlatformNotSupportedException & Add exception message box in App constructor #3283

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Jack251970
Copy link
Contributor

@Jack251970 Jack251970 commented Feb 26, 2025

From #3275.

@prlabeler prlabeler bot added the bug Something isn't working label Feb 26, 2025
Copy link

gitstream-cm bot commented Feb 26, 2025

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
jjw24, Jack251970 have most 🧠 knowledge in the files.

See details

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

Jack251970
FEB 19 additions & 13 deletions
JAN 86 additions & 66 deletions
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
Jack251970: 27%
jjw24: 9%

Flow.Launcher/Flow.Launcher.csproj

Activity based on git-commit:

Jack251970
FEB 3 additions & 2 deletions
JAN 4 additions & 2 deletions
DEC 4 additions & 0 deletions
NOV
OCT
SEP

Knowledge based on git-blame:
jjw24: 13%
Jack251970: 6%

To learn more about /:\ gitStream - Visit our Docs

This comment has been minimized.

Copy link

gitstream-cm bot commented Feb 26, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@Jack251970
Copy link
Contributor Author

@taooceros Hello, I am trying to fix System.PlatformNotSupportedException for installer here.

Copy link
Contributor

coderabbitai bot commented Feb 26, 2025

📝 Walkthrough

Walkthrough

This pull request enhances error handling in the application startup process. The App class constructor is modified to include try-catch blocks for initializing settings, the dependency injection container, and the public API. If exceptions occur, an error message is displayed, and the application exits. A new method, ShowErrorMsgBoxAndFailFast, centralizes error reporting. Additionally, the project file is updated to downgrade the versions of two package references due to compatibility issues.

Changes

File Change Summary
Flow.Launcher/App.xaml.cs Added try-catch blocks for settings and DI container initialization; introduced ShowErrorMsgBoxAndFailFast for centralized error handling.
Flow.Launcher/…/Flow.Launcher.csproj Downgraded Microsoft.Extensions.DependencyInjection (7.0.0 → 6.0.2) and Microsoft.Extensions.Hosting (7.0.0 → 6.0.1) due to TaskScheduler incompatibility.

Possibly related PRs

  • Fix Dependency Injection Issue #3275: Modifies error handling in the App class constructor and introduces the ShowErrorMsgBoxAndFailFast method, directly relating to the changes in this PR.

Suggested labels

enhancement, 5 min review

Suggested reviewers

  • jjw24
  • taooceros

Poem

I'm a little rabbit, hopping with delight,
In code so robust, everything's set right.
With try-catch hops and error leaps so keen,
I watch for faults where none are seen!
Carrots of code, fresh and true, 🥕
Celebrating changes with a playful "woo-hoo!"


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 397c6ee and 7cc32f3.

📒 Files selected for processing (1)
  • Flow.Launcher/App.xaml.cs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Flow.Launcher/App.xaml.cs
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@taooceros
Copy link
Member

I guess probably just upgrade to .net 9 would fix this

@Jack251970
Copy link
Contributor Author

We should not upgrade the version, but instead we need to downgrade it.

@taooceros
Copy link
Member

Task scheduler seems to use 8.0 dependency injection.

@taooceros
Copy link
Member

We should not upgrade the version, but instead we need to downgrade it.

yeah if it works then let's go with this first.

@Jack251970
Copy link
Contributor Author

Task scheduler seems to use 8.0 dependency injection.

Really? Let us try this first.

@Jack251970
Copy link
Contributor Author

Oh, I forget to clean old codes.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ ignored-expect-variant 1
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Jack251970
Copy link
Contributor Author

@taooceros Hello, can you download the installer? It seems that I have reached my daily limit...

@taooceros
Copy link
Member

@taooceros Hello, can you download the installer? It seems that I have reached my daily limit...

That's shared among all of us...

@taooceros
Copy link
Member

that's appveyor limit for a certain account (which is the same regardless who is trying to download)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 min review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants