Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5599 Add checks if rich-text option is enabled before removing support #5729

Merged
merged 2 commits into from
May 24, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented May 22, 2024

This PR adds check ensuring that rich-text is enable before ever removing rich text formatting. This solves the issue of having a prepended newlines when typing, for example, "HelloEnterWorld" where it produces

World
Hello

in the contenteditable.div in the master branch.

To test this manually:

1.) Open Gmail with FlowCrypt browser extension installed and configured.
2.) Send you're self a signed message email.
3.) Reply to your own signed message email. (The bug appears at this point on "master" branch but not here.)
4.) Type "HelloEnterWorld" and it will produce output on contenteditable.div correctly with:

Hello
World

instead of the bugged version:

World
Hello

close #5599


Tests (delete all except exactly one):

  • Difficult to test (explain why) - It's difficult to test it in automated manners for some reason as I get correct output's when doing testing for both master and this branch. So looks like the bug is particularly be reproducible through actual usage. I can share this build to the reporting users for them to double check it -- though it works perfectly when i tested it.

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner May 22, 2024 10:31
@martgil martgil marked this pull request as draft May 22, 2024 10:32
@martgil martgil marked this pull request as ready for review May 22, 2024 10:59
@martgil
Copy link
Collaborator Author

martgil commented May 22, 2024

Hello @sosnovsky - may I hear your feedback regarding this whenever your are available. Once confirmed that this looks good to you, I'll be sharing a custom build to the reporting users for them to see it working on their side before we can merge this. Thanks!

@sosnovsky
Copy link
Collaborator

Hi @martgil - I tried to reproduce mentioned bug on master build, but everything worked well for me.
Maybe you can share video of this issue by email?
You can also share this build with reporting users, to check if provided fix works for them.

@martgil
Copy link
Collaborator Author

martgil commented May 22, 2024

Yes, Roma - I just sent a screencast over secure email. Thanks!

@martgil
Copy link
Collaborator Author

martgil commented May 22, 2024

I will also create a custom build now and share to the reporting users.

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce original issue, and your fix works well 👍

@sosnovsky sosnovsky merged commit 27a27c8 into master May 24, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5599-better-rich-text-option-detection branch May 24, 2024 07:51
ioanmo226 pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure reply issues when composing signed message
2 participants