#5599 Add checks if rich-text option is enabled before removing support #5729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds check ensuring that rich-text is enable before ever removing rich text formatting. This solves the issue of having a prepended newlines when typing, for example, "HelloEnterWorld" where it produces
in the
contenteditable.div
in the master branch.To test this manually:
1.) Open Gmail with FlowCrypt browser extension installed and configured.
2.) Send you're self a signed message email.
3.) Reply to your own signed message email. (The bug appears at this point on "master" branch but not here.)
4.) Type "HelloEnterWorld" and it will produce output on
contenteditable.div
correctly with:instead of the bugged version:
close #5599
Tests (delete all except exactly one):
master
and this branch. So looks like the bug is particularly be reproducible through actual usage. I can share this build to the reporting users for them to double check it -- though it works perfectly when i tested it.To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):