Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create raspbian install script #171

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Create raspbian install script #171

merged 5 commits into from
Oct 6, 2023

Conversation

MarianRaphael
Copy link
Contributor

Description

Creation of a Raspbian install script

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@MarianRaphael MarianRaphael self-assigned this Sep 12, 2023
@MarianRaphael
Copy link
Contributor Author

MarianRaphael commented Sep 12, 2023 •
edited
Loading

Is "script" the correct folder in which to place an installation helper script?
Do we want such a script in the repo? Otherwise, I would just include it in docs?

hardillb
hardillb reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments

service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
service/raspbian-install-device-agent.sh Show resolved Hide resolved
MarianRaphael
MarianRaphael commented Oct 4, 2023
View reviewed changes
service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
service/raspbian-install-device-agent.sh Outdated Show resolved Hide resolved
@MarianRaphael MarianRaphael requested review from hardillb and removed request for knolleary October 4, 2023 07:59
@hardillb
Copy link
Contributor

hardillb commented Oct 5, 2023

@MarianRaphael Looks good, just needs the warning at the start updating to say it may ask for user password for sudo if not run as root.

@MarianRaphael
Copy link
Contributor Author

@hardillb I updated the script and added the info text

@MarianRaphael MarianRaphael merged commit 239c1c8 into main Oct 6, 2023
@MarianRaphael MarianRaphael deleted the install-script branch October 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees

@MarianRaphael MarianRaphael

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarianRaphael @hardillb