Enable WebSocket Affinity in the device agent #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of FlowFuse/flowfuse#2514 Reuses the affinity cookie if present, shares the affinity cookie with the forge platform if available.
|
Need to work out how to test this |
|
I've used the default Cookie name here, we may want to set it to a FF specific value. |
knolleary
reviewed
Jan 8, 2024
There was a problem hiding this comment.
As proposed in https://github.com/FlowFuse/flowfuse/pull/3173/files#r1445027729 - lets use FFSESSION for the cookie name
knolleary
reviewed
Jan 16, 2024
lib/editor/tunnel.js
Outdated
| socket.on('upgrade', (evt) => { | ||
| if (evt.headers && evt.headers['set-cookie']) { | ||
| const cookies = evt.headers['set-cookie'] | ||
| cookies.forEach(cookie => { |
There was a problem hiding this comment.
@hardillb Are we certain that evt.headers['set-cookie'] is always going to be an array? I don't readily have the means to verify this locally.
There was a problem hiding this comment.
I'll double check the WS code, but if I can't find a definitive answer I'll add some defensive code
knolleary
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of FlowFuse/flowfuse#2514
Description
As part of work to enable horizontal scaling of the Forge App, this allows the Device agent to use a cookie to bind to a specific instance (using Nginx Affinity mapping to start with).
Reuses the affinity cookie if present, shares the affinity cookie with the forge platform if available.
Related Issue(s)
FlowFuse/flowfuse#2514
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
backportlabelarea:migrationlabel