Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console.log(JSON) #219

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix console.log(JSON) #219

merged 2 commits into from
Jan 5, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jan 5, 2024

fixes #218

Description

If a node or a function node uses console.log() to output a JSON string then it would be parsed as a NR log message and break device logging in the UI

Related Issue(s)

#218

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.0 milestone Jan 5, 2024
@hardillb hardillb requested a review from knolleary January 5, 2024 10:42
@hardillb hardillb self-assigned this Jan 5, 2024
@knolleary knolleary merged commit 04b2625 into main Jan 5, 2024
2 checks passed
@knolleary knolleary deleted the handle-console-log-218 branch January 5, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Use of console.log in Function node can break device log streaming
2 participants
@hardillb @knolleary