Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent storage - Docker #103

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Persistent storage - Docker #103

merged 5 commits into from
Jul 29, 2024

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jul 15, 2024 •
edited
Loading

part of FlowFuse/flowfuse#4117

Description

Adds persistent storage to Docker driver

Related Issue(s)

FlowFuse/flowfuse#4117

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Jul 15, 2024
@hardillb hardillb requested a review from Steve-Mcl July 15, 2024 16:23
@hardillb hardillb marked this pull request as ready for review July 15, 2024 16:23
Steve-Mcl
Steve-Mcl approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than commented code, looks fine.

docker.js Outdated Show resolved Hide resolved
@hardillb @Steve-Mcl
Update docker.js
e932deb 
Co-authored-by: Stephen McLaughlin <[email protected]>
@hardillb hardillb merged commit f7d953a into main Jul 29, 2024
1 check passed
@hardillb hardillb deleted the persistent-storage branch July 29, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @Steve-Mcl