Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to customise service type created for project deployment #207

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

ppawlowski
Copy link
Contributor

Description

This pull request adds a possibility to define service type which is created for NodeRED instance deployment. Currently, only ClusterIP (default) and NodePort service types are supported.

Related Issue(s)

Closes FlowFuse/flowfuse#4041

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb March 2, 2025 19:35
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Just one suggestion in the README

Co-authored-by: Ben Hardill <[email protected]>
@ppawlowski ppawlowski requested a review from hardillb March 3, 2025 09:57
@hardillb hardillb merged commit 23a08c6 into main Mar 3, 2025
3 checks passed
@hardillb hardillb deleted the feat-nr-nodeport-svc branch March 3, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the option to use NodePort Services on Kubernetes
2 participants