Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JSON HTTP Request logging from the FileServer #82

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Allow JSON HTTP Request logging from the FileServer #82

merged 5 commits into from
Oct 3, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Oct 3, 2023

Description

Matching the behaviour of the forge app to default to JSON formatted HTTP Request logs

Related Issue(s)

#81

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.13 milestone Oct 3, 2023
@hardillb hardillb self-assigned this Oct 3, 2023
@hardillb hardillb requested a review from knolleary October 3, 2023 14:48
knolleary
knolleary requested changes Oct 3, 2023
View reviewed changes
forge/config.js Outdated Show resolved Hide resolved
@hardillb @knolleary
Update forge/config.js
d3453da 
Co-authored-by: Nick O'Leary <[email protected]>
@hardillb hardillb merged commit 5cc1293 into main Oct 3, 2023
4 checks passed
@hardillb hardillb deleted the json-logging branch October 3, 2023 16:02
@hardillb hardillb mentioned this pull request Oct 6, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
2 participants
@hardillb @knolleary