Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial schema generation for team-broker topics #4997

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Jan 9, 2025

Part of #4919

Description

Initial implementation of schema generation based on the observed team broker topics.

See #4919 for details on the schema and url used to expose.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with one comment

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (c0e2da7) to head (988e31c).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/teamBroker/schema.js 18.75% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4997      +/-   ##
==========================================
- Coverage   78.42%   78.36%   -0.06%     
==========================================
  Files         325      326       +1     
  Lines       15359    15377      +18     
  Branches     3530     3534       +4     
==========================================
+ Hits        12045    12050       +5     
- Misses       3314     3327      +13     
Flag Coverage Δ
backend 78.36% <27.77%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 3c9ec14 into main Jan 9, 2025
19 of 20 checks passed
@knolleary knolleary deleted the 4919-broker-schema branch January 9, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants