Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the version history tab to instance owned devices #5153

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Feb 20, 2025

Description

In the initial implementation I ported over the snapshots tab functionality that hid the tab when a device is owned by an instance. This doesn't apply to the version history nicely because it also hides the timeline tab/page.

I added a new empty state message to the snapshots page while making the version history tab visible.

Related Issue(s)

part of #5111

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.27%. Comparing base (ccafa56) to head (ee71af9).
Report is 6 commits behind head on add-device-pipeline-audit-log-event.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           add-device-pipeline-audit-log-event    #5153   +/-   ##
====================================================================
  Coverage                                78.27%   78.27%           
====================================================================
  Files                                      339      339           
  Lines                                    15989    15989           
  Branches                                  3698     3698           
====================================================================
  Hits                                     12515    12515           
  Misses                                    3474     3474           
Flag Coverage Δ
backend 78.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns changed the base branch from main to add-device-pipeline-audit-log-event February 20, 2025 11:09
@cstns cstns force-pushed the display-the-version-history-tab-to-instance-owned-devices branch from 5976eb1 to ee71af9 Compare February 20, 2025 13:57
@joepavitt joepavitt merged commit b79bb29 into add-device-pipeline-audit-log-event Feb 20, 2025
41 checks passed
@joepavitt joepavitt deleted the display-the-version-history-tab-to-instance-owned-devices branch February 20, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants