Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload/Selection #56

Open
joepavitt opened this issue Oct 12, 2022 · 8 comments
Open

File Upload/Selection #56

joepavitt opened this issue Oct 12, 2022 · 8 comments
Labels
area:frontend For any issues that require work in the frontend/UI size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@joepavitt
Copy link
Collaborator

Story

No response

Description

In need of a file selection/upload component that is consistent in style with the rest of Flowforge. First requirement for this came from FlowFuse/flowfuse#835.

For now, the solution was to use the standard HTML file upload input styling, but something more visually coherent would be preferable.

@joepavitt joepavitt added area:frontend For any issues that require work in the frontend/UI task A piece of work that isn't necessarily tied to a specific Epic or Story. new-component labels Oct 12, 2022
@joepavitt joepavitt moved this to Todo in 🛠 Development Oct 12, 2022
@hardillb
Copy link
Contributor

From my experiments in FlowFuse/flowfuse#1056 this component will need the following:

@joepavitt
Copy link
Collaborator Author

Properties:

  • File Types
  • "Type" of file upload, e.g. dragndrop or just single line "Choose File"

@hardillb
Copy link
Contributor

Also optional multi-file select

@joepavitt
Copy link
Collaborator Author

@sumitshinde-84 can't seem to assign you to this for some reason, but you're welcome to start the work on the forge-ui-components repo.

You can run npm run serve to get some interactive documentation (/docs) too which will give you some grounds on which to test the widgets works as expected.

@sumitshinde-84
Copy link

@sumitshinde-84 can't seem to assign you to this for some reason, but you're welcome to start the work on the forge-ui-components repo.

You can run npm run serve to get some interactive documentation (/docs) too which will give you some grounds on which to test the widgets works as expected.

Thank you for the information! I will start working on the forge-ui-components repo

@joepavitt joepavitt moved this from Todo to In Progress in 🛠 Development Jun 30, 2023
@joepavitt
Copy link
Collaborator Author

As a starting point take a look at the Vuetify File Upload component: https://vuetifyjs.com/en/components/file-inputs/ offers some good property examples. We'd ideally want drag & drop (and there are plenty of examples out there for that too)

@sumitshinde-84
Copy link

@joepavitt can you please review this Pr #2348 so i can freely move on this issue .

@joepavitt
Copy link
Collaborator Author

can you please review this Pr #2348 so i can freely move on this issue .

I can see that @Pezmc is handling that already, so will let him cover. That wouldn't be a blocker though, since forge-ui-components is a completely separate repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI size:M - 3 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Status: No status
Development

No branches or pull requests

4 participants