Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to create custom Network Policies for project pods #331

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

ppawlowski
Copy link
Contributor

Description

This PR introduces a feature which allows to configure custom Kubernetes Network Policies for NodeRed instances.
Additionally, it removes hardcoded and unused Network Policy.

Related Issue(s)

#322

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb February 27, 2024 20:16
@ppawlowski ppawlowski marked this pull request as draft February 27, 2024 21:20
@ppawlowski
Copy link
Contributor Author

The Helm chart validation is failing because during the upgrade process from the previous chart version to the current one, the --reuse-values flag is used. As a result, new default values shipped with the new chart version are ignored.
This issue has been already reported and some PR was already introduced.
However, until the chart-testing tool will not provide a possibility to configure the mentioned helm command parameter, there is a need to implement a workaround by validating all new chart values. The simplest way to achieve this is described here.

@ppawlowski ppawlowski marked this pull request as ready for review February 28, 2024 11:53
@hardillb hardillb merged commit 228c7d9 into main Feb 29, 2024
@hardillb hardillb deleted the feat-network-policies branch February 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants