-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customtoolnode): add return direct to custom tool #2594
feat(customtoolnode): add return direct to custom tool #2594
Conversation
@HenryHengZJ this image is different from version that I have pushed. I added a checkbox to turn return direct on. I am using this version and I am not facing this issue. I will check with latest branch main version. |
@HenryHengZJ I could reproduce the issue here. I will check what is happening and fix the issue. |
oh yeah I was hard-coding returnDirect to true in the code so |
I got it. 😉 |
@HenryHengZJ I did some changes in my code. I figured out that when agent try to call a custom tool with return direct with invalid parameters, automatically a empty text was being returned in a JSON format. I think this was the cause the bug that you have mentioned. |
hey @patrickreinan sorry for late response. I've added this PR that solve the issue: #3003, feel free to try it out and see if that works correctly. Closing this for now |
😉 |
Added return direct option to CustomTool node.