Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure OpenAI Embeddings ignores env variable AZURE_OPENAI_BASE_PATH #3452

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Azure OpenAI Embeddings ignores env variable AZURE_OPENAI_BASE_PATH #3452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/nodes/embeddings/AzureOpenAIEmbedding/AzureOpenAIEmbedding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class AzureOpenAIEmbedding_Embeddings implements INode {
azureOpenAIApiInstanceName,
azureOpenAIApiDeploymentName,
azureOpenAIApiVersion,
azureOpenAIBasePath: basePath
azureOpenAIBasePath: basePath || undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if you dont have basePath specified ? it will automatically becomes undefined? or was it an empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, basePath is an empty string by default, setting it to undefined instead of empty ensures that env variable AZURE_OPENAI_BASE_PATH is used instead of empty in @[email protected][email protected][email protected]/node_modules/@langchain/openai/dist/embeddings.cjs

}

if (batchSize) obj.batchSize = parseInt(batchSize, 10)
Expand Down
Loading