Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow null values for username and password - libcurl problems #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow null values for username and password - libcurl problems #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Classes/Domain/Model/Client/ClientConfiguration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ class ClientConfiguration
protected $scheme = 'http';

/**
* @var string
* @var string|null
*/
protected $username = '';

/**
* @var string
* @var string|null
*/
protected $password = '';

Expand Down Expand Up @@ -107,41 +107,41 @@ public function setScheme(string $scheme): void
/**
* Returns username
*
* @return string
* @return string|null
*/
public function getUsername(): string
public function getUsername(): ?string
{
return $this->username;
}

/**
* Sets username
*
* @param string $username
* @param string|null $username
* @return void
*/
public function setUsername(string $username): void
public function setUsername(?string $username): void
{
$this->username = $username;
}

/**
* Returns password
*
* @return string
* @return string|null
*/
public function getPassword(): string
public function getPassword(): ?string
{
return $this->password;
}

/**
* Sets password
*
* @param string $password
* @param string|null $password
* @return void
*/
public function setPassword(string $password): void
public function setPassword(?string $password): void
{
$this->password = $password;
}
Expand Down