feat: Terms of use web view #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonkamloic
reviewed
Mar 9, 2023
| @@ -8,7 +8,7 @@ class _AppColors { | |||
| static Color onErrorW = const Color(0xffFF000D); | |||
| // static Color bgColorW = const Color(0xffF7F7F7); | |||
| static Color bgColorW = Color(0xffFFFFFF); | |||
| static Color onBgColorW = Color(0xffD9D9D9); | |||
| static Color onBgColorW = Color(0xffF5F5F5); | |||
There was a problem hiding this comment.
Have you tested every other screen that uses this color to make sure it doesn't break?
@DesmondTambe is responsible for setting the right color.
Please revert this change.
There was a problem hiding this comment.
@fonkamloic right colors set already
fonkamloic
reviewed
Mar 9, 2023
fonkamloic
reviewed
Mar 9, 2023
fonkamloic
reviewed
Mar 9, 2023
| style: Theme.of(context).textTheme.titleSmall, | ||
| ), | ||
| Divider( | ||
| indent: (box.maxWidth / 2) - 100, |
There was a problem hiding this comment.
what does this calculation represent?
There was a problem hiding this comment.
The divider does not extend to the device's entire width.
So this calculation approximates the length of the text which is underlined.
jeffrey0606
previously approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy,///).