Add WeightNorm layer
#2053
Draft
Add WeightNorm layer
#2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the approach, would just advise to do performance tests as well. Due to compiler optimizations, I guess/hope this doesn't incur too much penalization. Also, would this work with recurrent layers? Perhaps define a new dispatch when it finds a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC as to whether this looks right, and whether the approach is a good one.
Needs tests.
Edit: earlier attempts are #993 (Dense only) and #1005. I had completely forgotten this, but the approach here is similar to @CarloLucibello's suggestion in #1005 (comment). (But I'm not sure why the forward pass is unchanged in the example there.)
Closes #942
Checklist