Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2086 re @autosize #2087

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Fix #2086 re @autosize #2087

merged 2 commits into from
Oct 16, 2022

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Oct 16, 2022 •
edited
Loading

Closes #2086

@mcabbott mcabbott merged commit 74bd04b into FluxML:master Oct 16, 2022
@mcabbott mcabbott deleted the autosize3 branch October 16, 2022 15:26
mcabbott
mcabbott commented Oct 16, 2022
View reviewed changes
test/outputsize.jl
Comment on lines +178 to +181
@test_broken begin # outputsize fails on Embedding
m = @autosize (2, 3, 4, 5) Embedding(_ => 10) # goes by first dim, not 2nd-last
@test randn(2, 3, 4, 5) |> m |> size == (10, 3, 4, 5)
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right, BTW.

Fixed in 179ac9b, in #2088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@autosize does not work with semi-colon separated kwargs
2 participants
@mcabbott @ToucheSir