remove params and Optimise from tests #2495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloLucibello
force-pushed
the
cl/depr2
branch
2 times, most recently
from
b4c7252
to
016dca9
Compare
remove Flux.params from tests broken deprecation in __old_to_new pen2
CarloLucibello
force-pushed
the
cl/depr2
branch
from
016dca9
to
2c3e257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving forward with the full deprecation of Flux.params and of the Optimise module, this removes them from tests.
After this only explicit differentiation and the Optimisers are used in the tests.
Moreover, now Flux exports the new optimisers from Optimisers.jl instead of the old Optimisers.
Should this change be considered breaking?
I guess it can break code for some people using implicit gradients.