Add more base types #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
force-pushed
the
iterators_etc
branch
from
d2c336d
to
c4ba662
Compare
|
I still don't understand why we shouldn't switch to an opt out semantics |
mcabbott
force-pushed
the
iterators_etc
branch
from
7ef8bad
to
6f5705c
Compare
|
I would favour doing that, eventually. It's probably got to be done with a breaking release of Flux. This PR moves us a little closer to traversing everything. Fix2 in particular came up in FluxML/Flux.jl#2107 |
|
Same, I am in favor (and in fact have a branch doing something like this), but it will require many more tests than we currently have. It would be a candidate for v0.5, but it would be nice to get v0.4 out soon. |
CarloLucibello
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28, intended for 0.4 release
So far aims to add all of Base.Iterators, and Fix1, Fix2, Pair. Are there other obvious things to add?
Needs tests.
PR Checklist