Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AMDGPU compat to 0.6 #530

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Bump AMDGPU compat to 0.6 #530

merged 1 commit into from
Sep 19, 2023

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Sep 9, 2023

And drop 0.4

PR Checklist

  • Tests are added
  • Documentation, if applicable

@pxl-th
Copy link
Member Author

pxl-th commented Sep 11, 2023

Maybe we should add CUDA/AMDGPU/etc. to Project.toml only if get(ENV, "NNLIB_TEST_CUDA", "false") == "true" with Pkg.add("CUDA")?
This would avoid potential incompatibilities between the two packages.

@CarloLucibello
Copy link
Member

Maybe we should add CUDA/AMDGPU/etc. to Project.toml only if get(ENV, "NNLIB_TEST_CUDA", "false") == "true" with Pkg.add("CUDA")?

you suggest we use Pkg.add(...) inside the if blocks in runtests.jl file? We can do that. Let's merge #531 first though.

@CarloLucibello CarloLucibello merged commit 8c41cf3 into master Sep 19, 2023
10 of 12 checks passed
@pxl-th pxl-th deleted the pxl-th/amdgpu-compat branch June 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants