rework cmake to allow for integrations in other projects #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your work! However, please don’t rename executable name, that will break existing package users. Thanks |
|
done |
Windows doesn't usually use lib prefix
|
That's much better, thanks. Will merge after some tests. |
|
Sorry but I had to revert this change as it broke existing behaviour, ryzenadj(cli) must be linked statically against libryzenadj. |
|
didn't know that, is it the only issue? i mean, open new pr or just push here and re-merge? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor includes clean up
fix warning due to missing include(GNUInstallDirs) in ryzenadj app cmake (on make install)
give libryzenadj its own cmake file
add install command to libryzenadj (also useful to make lib pkg for linux)
fix WinRing linking when building libryzenadj in a project
fix export errors when building libryzenadj in a project
renamed ryzenadj project to ryzenadjcli to avoid project name issues in Visual Studio and keep library project name as ryzenadj so that we have auto-naming with cmake (libryzenadj)
cmd/shell/IDE build tested on linux and windows 11, project integration as submodule tested on linux and windows 11
on linux, install will create
on Windows