Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change program id to "tag-$id" #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nmichaud
Copy link
Collaborator

@nmichaud nmichaud commented Jun 9, 2024

This will also help with having non-tag based programs in the future

This will also help with having non-tag based programs in
the future
@nmichaud nmichaud requested a review from osnr June 9, 2024 23:40
@osnr
Copy link
Collaborator

osnr commented Jun 10, 2024

I don't love the tag-$id thing because I think the object should be identified with the entire page, not the AprilTag alone -- page-$id or program-$id would probably be better

@osnr
Copy link
Collaborator

osnr commented Jun 10, 2024

or printed-program-$id I guess

@nmichaud
Copy link
Collaborator Author

Sure, although I'd like to be able to continue differentiating between different tag families (since they both encode numeric ids) since I use both (the standard one for small programmable objects and the other family for the dual tags). In some ways I feel like the id shouldn't even be visible to the end user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants