[sdk]: Include .c and .h items by default
#597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems unhappy with the changes. Could you please take a look? |
|
There was a problem likely caused by us caching the templates produced during tests, in system-wide nuget cache. I'll take a look at that: we should not use the system cache during template/sdk tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574
Instead of just ignoring all default items with
EnableDefaultItems=falseI decided to switch off all particular default item groups except the ones included inCompileitems. This allows us to be better integrated with common SDK properties.Since
DefaultLanguageSourceExtensiononly supports 1 extension, others like.hwere added separately with the same switching logic.For the reference I used Microsoft.NET.Sdk.DefaultItems.props