Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code generation for functions #637

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Improve code generation for functions #637

merged 1 commit into from
Sep 5, 2024

Conversation

kant2002
Copy link
Collaborator

@kant2002 kant2002 commented Sep 5, 2024

  • Allow missing return for non void functions.
  • Make sure that unreachable code at the end of file has ret instruction.

Closes #633

@kant2002
Improve code generation for functions
1bfa7f4 
- Allow missing return for non void functions.
- Make sure that unreachable code at the end of file has ret instruction.
@ForNeVeR ForNeVeR self-requested a review September 5, 2024 19:55
@ForNeVeR ForNeVeR self-assigned this Sep 5, 2024
ForNeVeR
ForNeVeR approved these changes Sep 5, 2024
View reviewed changes
Copy link
Owner

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ForNeVeR ForNeVeR merged commit 453874f into ForNeVeR:main Sep 5, 2024
3 checks passed
@kant2002 kant2002 deleted the kant/improve-codegen-function branch September 8, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

Assignees

@ForNeVeR ForNeVeR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endless loop compiled with ret in the beginning
2 participants
@kant2002 @ForNeVeR