Allow initialization of char ptr array #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant2002
force-pushed
the
kant/init-charptr-arr
branch
from
4ec185f
to
b7cad02
Compare
slyshykO
reviewed
Sep 7, 2024
| public Task ArrayCharComparison() => DoTest(@" | ||
| int main() { | ||
| const char a[1] = { 'A' }; | ||
| if (a[0] != 'D') { |
There was a problem hiding this comment.
Why is there a check for 'D' despite the array being initialized with 'A'?
There was a problem hiding this comment.
I test what’s generated. I need comparison with any char literal. Does not matter what.
There was a problem hiding this comment.
Yeah. This doesn't matter. We don't even run this code. It's for the purpose of dumping the codegen results. So, more variety (within some measure of course) — more chances the tests will catch unexpected codegen changes. This is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.