fix(sse): detect buffering and warn user #1256

DayTF · 2025-01-30T15:06:15Z

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

realSpok · 2025-01-31T09:33:01Z

packages/forestadmin-client/src/events-subscription/index.ts

+    eventSource.addEventListener(
+      'open',
+      () => eventSource.addEventListener('open', () => this.onEventOpenAgain()),
+      { once: true },


why did you change it to once here ?

To prepare a migration to EventSource@v3, as it is removed from that version
EventSource@v3 is necessary for Deno runtime, which some users/lumberjacks have shown interest into

packages/forestadmin-client/src/events-subscription/index.ts

realSpok

✅ PR title
✅ PR linked to the clickup task
✅ The PR tackle one subject only
✅ Destination branch
✅ Code review
- ℹ️ Use pure functions when possible
- ✅ Performance concerns
- ✅ Security concerns
- ✅ Check that nothing introduces a breaking change, including the types
✅ Automatic tests
- ✅ Unit tests
- ⤬ Integration tests
✅ Manual tests
- ✅ Test the functionality
- ✅ Test error cases

codeclimate · 2025-01-31T10:02:13Z

Code Climate has analyzed commit 5df2e60 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.2%.

View more on Code Climate.

## [1.13.7](https://github.com/ForestAdmin/agent-nodejs/compare/[email protected]@1.13.7) (2025-01-31) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4))

forest-bot · 2025-01-31T14:51:51Z

🎉 This PR is included in version 1.12.25 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-31T14:51:58Z

🎉 This PR is included in version 1.13.7 🎉

The release is available on [email protected]

Your semantic-release bot 📦🚀

## [1.58.5](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-31) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) ### Features * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

## [1.36.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-01-31) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) ### Features * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

forest-bot · 2025-01-31T14:52:16Z

🎉 This PR is included in version 1.58.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-01-31T14:52:31Z

🎉 This PR is included in version 1.36.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2025-02-05T10:07:50Z

🎉 This PR is included in version 1.4.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.61.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

## [1.1.50](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

forest-bot · 2025-02-05T10:08:38Z

🎉 This PR is included in version 1.61.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.10.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6))

# [1.6.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

## [1.11.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

## [1.16.7](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

# [1.48.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

forest-bot · 2025-02-05T10:09:08Z

🎉 This PR is included in version 1.1.50 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.4.18](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

## [1.1.24](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

forest-bot · 2025-02-05T10:09:23Z

🎉 This PR is included in version 1.10.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.4.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/[email protected]...@forestadmin/[email protected]) (2025-02-05) ### Bug Fixes * **sse:** detect buffering and warn user ([#1256](#1256)) ([dc4fdf4](dc4fdf4)) * **user-permission:** don't cache rejected promises ([#1248](#1248)) ([10bd993](10bd993)) ### Features * add environment and project name in caller ([#1200](#1200)) ([819f5f6](819f5f6)) * **mongoose:** allow to enable debug mode ([#1251](#1251)) ([db36f93](db36f93))

forest-bot · 2025-02-05T10:09:38Z

🎉 This PR is included in version 1.6.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

fix(sse): detect buffering and warn user

bbc4d7e

DayTF force-pushed the fix/detect-sse-buffering branch from 6323305 to bbc4d7e Compare January 30, 2025 15:07

Dogan AY added 5 commits January 30, 2025 16:13

fix: lint

35cca4b

fix: some tests

c620a0d

chore: update github action version

0336391

fix: github action version

d5836f1

feat: testing

05f46c0

realSpok reviewed Jan 31, 2025

View reviewed changes

packages/forestadmin-client/src/events-subscription/index.ts Outdated Show resolved Hide resolved

realSpok reviewed Jan 31, 2025

View reviewed changes

packages/forestadmin-client/src/events-subscription/index.ts Outdated Show resolved Hide resolved

realSpok approved these changes Jan 31, 2025

View reviewed changes

Dogan AY added 3 commits January 31, 2025 10:40

fix: code review

895073b

fix: again

d101e3e

fix: remove whitespace

5df2e60

DayTF merged commit dc4fdf4 into main Jan 31, 2025
22 checks passed

DayTF deleted the fix/detect-sse-buffering branch January 31, 2025 10:05

forest-bot added the released label Jan 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sse): detect buffering and warn user #1256

fix(sse): detect buffering and warn user #1256

DayTF commented Jan 30, 2025

realSpok Jan 31, 2025

DayTF Jan 31, 2025

realSpok left a comment

codeclimate bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

fix(sse): detect buffering and warn user #1256

fix(sse): detect buffering and warn user #1256

Conversation

DayTF commented Jan 30, 2025

Definition of Done

General

Security

realSpok Jan 31, 2025

Choose a reason for hiding this comment

DayTF Jan 31, 2025

Choose a reason for hiding this comment

realSpok left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Jan 31, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025

forest-bot commented Feb 5, 2025