Skip to content

Commit

Permalink
chore: switch from semi column to column
Browse files Browse the repository at this point in the history
  • Loading branch information
SteveBunlon committed Dec 7, 2023
1 parent 5b3f503 commit 05cbf75
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/services/dumpers/agent-nodejs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export default class AgentNodeJs extends AbstractDumper {
Object.entries(fieldsDefinition).forEach(([key, fieldDefinition]) => {
if (key.includes(':')) {
this.logger.warn(
`Ignoring field ${key} from collection ${collectionName} as it contains semi column and is not valid.`,
`Ignoring field ${key} from collection ${collectionName} as it contains column and is not valid.`,
);

delete fieldsDefinition[key];
Expand All @@ -279,7 +279,7 @@ export default class AgentNodeJs extends AbstractDumper {
return compliantFieldsDefinition.reduce((correctFieldsDefinitions, definition) => {
if (definition.name.includes(':')) {
this.logger.warn(
`Ignoring field ${definition.name} from collection ${collectionName} as it contains semi column and is not valid.`,
`Ignoring field ${definition.name} from collection ${collectionName} as it contains column and is not valid.`,
);
} else {
correctFieldsDefinitions.push(definition);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,13 @@ describe('services > dumpers > agentNodejsDumper > mongoose models', () => {

expect(loggerWarnSpy).toHaveBeenCalledTimes(3);
expect(loggerWarnSpy).toHaveBeenCalledWith(
'Ignoring field name:column from collection persons as it contains semi column and is not valid.',
'Ignoring field name:column from collection persons as it contains column and is not valid.',
);
expect(loggerWarnSpy).toHaveBeenCalledWith(
'Ignoring field answer:column from collection persons as it contains semi column and is not valid.',
'Ignoring field answer:column from collection persons as it contains column and is not valid.',
);
expect(loggerWarnSpy).toHaveBeenCalledWith(
'Ignoring field so:column from collection persons as it contains semi column and is not valid.',
'Ignoring field so:column from collection persons as it contains column and is not valid.',
);
});
});
Expand Down

0 comments on commit 05cbf75

Please sign in to comment.