Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for node 16 #664

Closed
wants to merge 3 commits into from
Closed

chore: add tests for node 16 #664

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a859e4
chore: add tests for node 16
Feb 6, 2024
4767714
chore: fix the command
Feb 6, 2024
af114e0
chore: ignore engines on node 16
Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
needs: [lint]
strategy:
matrix:
node: [18, 20]
node: [16, 18, 20]
include:
- node: 18
withCoverage: ${{ true }}
Expand All @@ -79,6 +79,9 @@ jobs:
run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
- name: Start docker container
run: docker-compose up -d; sleep 15
- name: Ignore engines
if: matrix.node == 16
run: yarn config set ignore-engines true
- name: Test with Node ${{ matrix.node }}
if: ${{ !matrix.withCoverage }}
run: yarn test
Expand Down
Loading