Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update-renovate-config #71

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: update-renovate-config #71

merged 2 commits into from
Feb 13, 2025

Conversation

ryanbas21
Copy link
Collaborator

@ryanbas21 ryanbas21 commented Feb 13, 2025

Groups renovate dependencies so theres less noise. add nx to ignore pattern since we do that with nx.

Unfortunately, the ignore pattern is exact match only and not glob

adds a GH action that will add changesets for the deps when they are needed. uses https://www.npmjs.com/package/@scaleway/changesets-renovate

Which is seen here: https://github.com/scaleway/scaleway-lib/blob/94fd991db6ac46ea034d486837e4ca4dbc38d8c3/.github/workflows/changesets-renovate.yml

Which I looked at how some of these actions are run here: scaleway/scaleway-lib#2402

Reason: Some updates require changesets. Simple as that, I have it set right now that only devDependencies will get auto merged, and non-major changes.

So if we update a dependency that may require a changeset.

For example: #22 probably requires a changeset, since its a "dependency upgrade" (if we wanted to merge it).

Caveat: I do not see this working for pnpm catalogs.

basically the catalog defines a range, and then renovate mostly just updates the lockfile. So this is probably fine since we aren't actually changing the version range within the package.

If we do, we would do it manually in the pnpm-workspace file and then make our own changeset.

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 7334a13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Feb 13, 2025

View your CI Pipeline Execution ↗ for commit 7334a13.

Command Status Duration Result
nx affected -t typecheck build lint test docs e... ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-13 02:56:45 UTC

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Deployed 1cb85e1 to https://ForgeRock.github.io/ping-javascript-sdk/pr-71/1cb85e17eae2cbfe090bfe9936e3d4cec7511227 branch gh-pages in ForgeRock/ping-javascript-sdk

@ryanbas21 ryanbas21 force-pushed the renovate/reconfigure branch from e181d32 to 57047b1 Compare February 13, 2025 01:44
@ryanbas21 ryanbas21 force-pushed the renovate/reconfigure branch from 0a5d8f8 to 7334a13 Compare February 13, 2025 02:54
@ryanbas21 ryanbas21 merged commit e9c8ba9 into main Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant